driver: espi: implement espi PM function #94200

JasonLin-RealTek · 2025-08-07T06:06:55Z

add cs pin as espi driver wake up reference
removed the unnecessary update of the cached date
removed the unnecessary busy wait in notify funciton

keith-zephyr · 2025-08-11T16:25:52Z

drivers/espi/espi_realtek_rts5912.c

+#include <zephyr/pm/device.h>
+#include <zephyr/pm/policy.h>
+#include "reg/reg_system.h"
+#define RTS5912_SCCON_REG_BASE    ((SYSTEM_Type *)(DT_REG_ADDR(DT_NODELABEL(sccon))))


Is this macro already defined by reg/reg_system.h?

keith-zephyr · 2025-08-11T16:28:04Z

drivers/espi/espi_realtek_rts5912.c

+#define ESPI_RTS5912_ESPI_CS_PORT DEVICE_DT_GET(DT_NODELABEL(gpioa))
+#define ESPI_RTS5912_ESPI_CS_PIN  4


Add a property to the realtek,rts5912-espi node to get the wakeup GPIO information instead of hardcoding.

We use gpios = <&gpioa 4 0>; in device tree to get CS Pin Information, thanks.

keith-zephyr · 2025-08-26T07:47:50Z

drivers/espi/espi_realtek_rts5912.c

+	gpio_flags_t cs_pin_config;

+	gpio_pin_get_config(port, pins, &cs_pin_config);
+	if (cs_pin_config & GPIO_GCR_INTEN_Msk) {


GPIO_GCR_INTEN_Msk is an internal bit for the GPIO controller. You should check standard flags defined by gpio.h and gpio_defines.h

Suggested change

if (cs_pin_config & GPIO_GCR_INTEN_Msk) {

if (cs_pin_config & GPIO_INT_ENABLE) {

Thanks, fixed.

keith-zephyr · 2025-08-26T07:50:01Z

dts/bindings/espi/realtek,rts5912-espi.yaml

  pinctrl-names:
    required: true
+
+  gpios:


Name this cs-gpios. You should also add some help text to describe this property.

Fixed and add the description in yaml.

keith-zephyr · 2025-08-26T07:52:38Z

dts/arm/realtek/ec/rts5912.dtsi

 				0x400a0100 0x1c			/* KBC */
-				0x400B1600 0xd0>;		/* MBX */
+				0x400B1600 0xd0			/* MBX */
+				0x40090010 0x04>;		/* CS pin */


The cs_low reg entry has been replaced by the gpios property, so this is no longer used.

Removed it now.
0x40090010 0x04>; /* CS pin */

keith-zephyr · 2025-09-11T20:34:55Z

dts/arm/realtek/ec/rts5912.dtsi

 				"emi7", "oob_tx", "oob_rx",
 				"oob_chg", "maf_tr", "flash_chg",
-				"port80", "mbx";
+				"port80", "mbx", "cs_low";


I believe the cs_low interrupt is also unused. Please delete from both interrupt-names and from interrupts above.

Fixed, thanks.

cs_low is still listed in the interrupt names, and interrupt <4 0> is still listed in interrupt properties.

Sorry, delete them now.

fabiobaltieri · 2025-09-26T16:49:44Z

@JasonLin-RealTek hey give this a rebase (on current main), there was a transient CI issue.

JasonLin-RealTek · 2025-10-03T08:27:33Z

@JasonLin-RealTek hey give this a rebase (on current main), there was a transient CI issue.

Hi @fabiobaltieri , fixed, thanks.

keith-zephyr · 2025-10-07T17:46:18Z

dts/bindings/espi/realtek,rts5912-espi.yaml

+
+  cs-gpios:
+    description: |
+      select the cs pin to support the espi wakeup


Add a note that this property is required if CONFIG_PM is enabled.

Add a note now, thanks.

1. add cs pin as espi driver wake up reference 2. removed the unnecessary update of the cached date 3. removed the unnecessary busy wait in notify funciton Signed-off-by: Lin Yu-Cheng <[email protected]>

sonarqubecloud · 2025-10-08T01:41:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JasonLin-RealTek requested a review from keith-zephyr August 7, 2025 06:07

zephyrbot added area: eSPI eSPI platform: Realtek EC labels Aug 7, 2025

zephyrbot requested review from VenkatKotakonda, albertofloyd and jvasanth1 August 7, 2025 06:07

zephyrbot assigned JasonLin-RealTek Aug 7, 2025

keith-zephyr reviewed Aug 11, 2025

View reviewed changes

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch 2 times, most recently from 419e686 to 12ad3ef Compare August 21, 2025 02:06

keith-zephyr reviewed Aug 26, 2025

View reviewed changes

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from 12ad3ef to 9c30eba Compare September 5, 2025 09:59

keith-zephyr requested changes Sep 11, 2025

View reviewed changes

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from 9c30eba to d56a0c9 Compare September 12, 2025 09:33

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from d56a0c9 to da5a6ee Compare September 22, 2025 12:23

keith-zephyr previously approved these changes Sep 22, 2025

View reviewed changes

keith-zephyr requested a review from fabiobaltieri September 25, 2025 20:23

fabiobaltieri previously approved these changes Sep 26, 2025

View reviewed changes

JasonLin-RealTek dismissed stale reviews from fabiobaltieri and keith-zephyr via 8c0a1cf September 26, 2025 12:53

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from da5a6ee to 8c0a1cf Compare September 26, 2025 12:53

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from 8c0a1cf to da21ff3 Compare October 2, 2025 02:45

zephyrbot added area: Devicetree Bindings area: Boards/SoCs labels Oct 2, 2025

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from da21ff3 to afd3423 Compare October 2, 2025 11:09

fabiobaltieri previously approved these changes Oct 3, 2025

View reviewed changes

keith-zephyr reviewed Oct 7, 2025

View reviewed changes

driver: espi: implement espi PM function

1dee6d6

1. add cs pin as espi driver wake up reference 2. removed the unnecessary update of the cached date 3. removed the unnecessary busy wait in notify funciton Signed-off-by: Lin Yu-Cheng <[email protected]>

JasonLin-RealTek dismissed fabiobaltieri’s stale review via 1dee6d6 October 8, 2025 01:16

JasonLin-RealTek force-pushed the implement_espi_power_consumption branch from afd3423 to 1dee6d6 Compare October 8, 2025 01:16

keith-zephyr approved these changes Oct 8, 2025

View reviewed changes

		#define ESPI_RTS5912_ESPI_CS_PORT DEVICE_DT_GET(DT_NODELABEL(gpioa))
		#define ESPI_RTS5912_ESPI_CS_PIN 4

	if (cs_pin_config & GPIO_GCR_INTEN_Msk) {
	if (cs_pin_config & GPIO_INT_ENABLE) {

driver: espi: implement espi PM function #94200

Are you sure you want to change the base?

driver: espi: implement espi PM function #94200

Conversation

JasonLin-RealTek commented Aug 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri commented Sep 26, 2025

Uh oh!

JasonLin-RealTek commented Oct 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants